Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unwanted +33 with email from verify message #42

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Fix unwanted +33 with email from verify message #42

merged 1 commit into from
Aug 22, 2024

Conversation

Stef-Rousset
Copy link
Contributor

🎩 Description
When signing up with email, remove the +33 in the verify message "Vous devriez avoir reçu le code à..."

📌 Related Issues
Notion card

Testing

  1. As an admin, "Enable partial sign up and sign in using SMS verification" and "Enable partial sign up and sign in using email verification" in the settings
  2. As a user, in french locale, go to sign up, choose email, enter an email and in the verify page, check that you don't have the +33 in the message above the code to enter (cf screenshot)

Screenshot
Capture d’écran 2024-08-21 à 15 23 32

luciegrau
luciegrau approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@luciegrau luciegrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and it works great, thank you!

BarbaraOliveira13
BarbaraOliveira13 approved these changes Aug 22, 2024
View reviewed changes
Copy link

@BarbaraOliveira13 BarbaraOliveira13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🎉

@luciegrau luciegrau merged commit dd30b80 into main Aug 22, 2024
6 checks passed
@luciegrau luciegrau deleted the fix/verify_message branch August 22, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BarbaraOliveira13 BarbaraOliveira13 BarbaraOliveira13 approved these changes

@luciegrau luciegrau luciegrau approved these changes

@moustachu moustachu moustachu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Stef-Rousset @moustachu @luciegrau @BarbaraOliveira13